The extension finds all the files but not the cartrdiges that contain them.

jeroen-emakinanl commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the Bug

First of all, nice work, I can totally see this making my life easier.

After I installed the extension and configured the cartridge path in the settings, it does not show any cartridges in the extensions sidebar.

the extension output does mention this: › Fetching SFCC Cartridges from Workspace ...

› Overrides Only: Disabled

✔ Found 1,747 files in 0 Cartridges in Workspace

So it does seem to find the source files, it just isn't able to assign them to cartridges properly.

I added a screenshot of my workspace project structure (with the client name redacted) that will hopefully help in tracking down the detection issue. SFCC is the workspace root folder.

Please let me know if you require more information, as you can understand I am unable to share my actual code base with you as that is not my property.

Steps To Reproduce

Please see the issue description, I basically followed he manual but not seeing the result I expected

Expected Behavior

No response

Screenshots

afbeelding

Environment

- OS: Windows 10 Enterprise 22H2
- Node: v16.19.1
- npm: v8.19.3

Additional Context

No response

manifestinteractive commented 1 year ago

Any chance you're missing setting your cartridge path in the Workspace VS Code? You might need to check also which setting location ( Global vs Workspace vs User ) you're using.

For example, I see you have a .vscode folder, so if you've got setting in there, you'll likely need to put that setting there.

If you're using a workspace file, it'll need to be saved there. Basically, just check that wherever your workspace settings are saved, that's also where this path is set.

It's easy in VS Code to save settings to your User vs Workspace vs Global, so that seems like that's what happened.

Troubleshooting doc here:

https://github.com/sfccdevops/sfcc-cartridge-overrides-vscode-extension/blob/develop/TROUBLESHOOTING.md#working-with-multiple-sites

jeroen-emakinanl commented 1 year ago

Hi, thanks for the quick reply.

I did find that, and I had already filled in the workspace level setting like you mentioned. here is my .code-workspace file (with redacted client name). it lives outside of the main folder (SFCC) because we don't want it in the repo

{ "folders": [ { "path": "SFCC" } ], "settings": { "extension.sfccCartridges.path": "app_pagedesigner_sg:app_clientnamel:int_adyen_overlay:int_adyen_controllers:bc_integrationframework:bc_library:int_webservicesnl:bm_jobs:int_monitor:app_sitegenesis:int_klarna:int_notifyme:int_crosscloud_sfsc:sitegenesis_controllers:sitegenesis_core:module_pagedesigner" } }

jeroen-emakinanl commented 1 year ago

A quick update. I can get the extension to work on another client project, but that is much more modern (it is SFRA).

the project I have a problem with is a really old, poorly maintained, SiteGenesis pipelines proiect, I hope that is also supported, as I was really looking forward to using your extension to unravel this steaming pile of mess :)

manifestinteractive commented 1 year ago

Any chance you can copy the output from the extension debugger? Instructions are in that troubleshooting doc.

jeroen-emakinanl commented 1 year ago

this is the full output (client redacted again) as copied form the extension Output

WORKSPACE: c:\WORK\Projects\ClientName\SFCC

WORKSPACE: c:\WORK\Projects\ClientName\SFCC CARTRIDGE PATH:

app_pagedesigner_sg
app_ClientName
int_adyen_overlay
int_adyen_controllers
bc_integrationframework
bc_library
int_webservicesnl
bm_jobs
int_monitor
app_sitegenesis
int_klarna
int_notifyme
int_crosscloud_sfsc
sitegenesis_controllers
sitegenesis_core
module_pagedesigner

WORKSPACE: c:\WORK\Projects\ClientName\SFCC

› Fetching SFCC Cartridges from Workspace ...

› Overrides Only: Disabled

✔ Found 1,747 files in 0 Cartridges in Workspace

manifestinteractive commented 1 year ago

Thanks. I've got enough info to look into this now :)

thaohoangthu commented 1 month ago

Hi, Is there any update for this bug? I got the same issue today 👍

manifestinteractive commented 1 month ago

Sadly, I was not able to duplicate it. Not even close for that matter. Was hoping I got another env I could trigger it on over the following few days ... but never happened.

My apologies for dropping the ball on updating this ticket. I always feel weird marking them as "Unable to duplicate" as I feel like you've clearly proven it's happening, so wanted to test out as many different projects over time, figuring it'd popup in at least one of them :(

sfccdevops / sfcc-cartridge-overrides-vscode-extension