search

sfcpc / housing-dashboard

4 stars 0 forks source link

[Relational] [Ramp Up Exercise] Fill out supervisor district and applicant for all sources that have it #171

Open rajpara11 opened 4 years ago

rajpara11 commented 4 years ago

This should be an easy bug.

In the gen_facts method in table.py we attempt to go through all the data sources in order and use them to fill out information about the project. Unfortunately we don't always fill out the supervisor district and applicant info (it isn't filled for the Planning data source right now). We don't have this data for DBI (I believe) so this may be the only place where we need to fill it out where we don't have it.

We should fill out this information and make sure test_table has a valid unit test for this logic as well.

Ensure you run 'flake8' to make sure the change conforms to style guidelines and 'pytest' to make sure any old (and new) tests pass

rajpara11 commented 4 years ago

I think we're trying to expose this soon so I'll just grab it for now and do it, there's still another bug for Mike to tackle on relational side for now