search

sfcpc / housing-dashboard

4 stars 0 forks source link

Pull in some PTS data for some of the numbers #51

Closed thelee closed 4 years ago

thelee commented 4 years ago

Boy this inflates our project_facts table by an order of magnitude and I'm not altogether clear if this is right.

thelee commented 4 years ago

did some pretty significant additional changes to fix some bugs, PTAL

thelee commented 4 years ago

I had missed your earlier PRs so I had to spend some time reading and working to understand what's going on. In general, there are more tuples, lists, and dicts than I'm comfortable with.

stylistically, named tuples are no good?

I wonder if refactoring it to move these generators onto subclasses of Entry or Project would be cleaner? What have you explored?

nothing - this was the fastest/firstest i spat out :)

LGTM because my aesthetic concerns aren't important enough to block any work. It could be something we come back to later, if at all.

thelee commented 4 years ago

LGTM because my aesthetic concerns aren't important enough to block any work. It could be something we come back to later, if at all.

i'm going to go ahead and merge this so we can generate some PTS data (without lots of bugs) but i'll keep an eye on tightening this stuff up.