search

sfcpc / ifc

SF Planning Impact Fee Calculator
https://sfcpc.github.io/ifc/
1 stars 1 forks source link

All GSF numbers should have commas to be easier to read. #148

Open adamlodge opened 6 years ago

adamlodge commented 6 years ago

This is already implemented in reports, but not in data entry forms.

mikewynne commented 5 years ago

@robgaston Is this a major headache to implement? I could imagine that it might be. If it is then I think we should just close this one out. If it's not then it's worth doing.

robgaston commented 5 years ago

@mikewynne it's simple to implement (and should be implemented, though there may be exceptions that fell through the cracks) on the report page. the place where this is hard to implement is in the forms where each character is by default assumed to be a part of the value the user has entered.

mikewynne commented 5 years ago

@robgaston Cool, thanks. I think the original feedback was more about the display of the input and calculate forms - so that typing 10000 would automatically display as 10,000.

robgaston commented 5 years ago

@mikewynne sorry, I may have been a bit imprecise above in my language. It is in the input and calculate forms where this will be difficult to implement (it should already be implemented in the report page). I'm guessing a day or two to figure it all out, but there are some unknowns there which make it tough to estimate. Do you still want us to try to take this on?

Thanks!

mikewynne commented 5 years ago

@robgaston Let's leave it until the end, if we have hours left over after everything else is finished it might be worth spending time on. I'll move it back to the Icebox for now.

robgaston commented 5 years ago

@mikewynne we built something for Arches (which also uses knockout) that allows for displaying commas in number inputs which we can probably use to satisfy this request. Let me know if you would like us to proceed w/ implementing this in IFC.

mikewynne commented 5 years ago

@robgaston I'd say leave that for now, seeing as it's such a low priority. thanks