search

sfdx-isv / sfdx-falcon

A Salesforce CLI Plugin that enables and enhances implementation of the SFDX-Falcon family of projects, including the AppExchange Demo Kit (ADK) and AppExchange Package Kit (APK)
https://sfdx-isv.github.io/sfdx-falcon/
38 stars 6 forks source link

An in-range update of sinon is breaking the build 🚨 #130

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency sinon was updated from 7.2.3 to 7.2.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sinon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **ci/circleci: node-8:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/724?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: node-latest:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/723?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
Commits

The new version differs by 13 commits.

  • 06fc27d Update docs/changelog.md and set new release id in docs/_config.yml
  • 54da371 Add release documentation for v7.2.4
  • e5de1fe 7.2.4
  • d158672 Update CHANGELOG.md and AUTHORS for new release
  • 1431c78 minor package updates
  • 37c955d Merge pull request #1979 from fatso83/update-npm-deps
  • fc2a32a Merge pull request #1975 from ehmicky/master
  • 85f2fcd Update eslint-plugin-mocha
  • 707e068 Fix high prio audit warnings
  • 8282bc0 Update nise to use @sinonjs/text-encoding
  • c1d9625 Make all properties non-enumerable in spies, stubs, mocks and fakes
  • 894951c Merge pull request #1973 from mgred/default-sandbox-example
  • 876aebb docs(sandbox): add example for default sandbox

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 7.2.3 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.