search

sfdx-isv / sfdx-falcon

A Salesforce CLI Plugin that enables and enhances implementation of the SFDX-Falcon family of projects, including the AppExchange Demo Kit (ADK) and AppExchange Package Kit (APK)
https://sfdx-isv.github.io/sfdx-falcon/
37 stars 6 forks source link

An in-range update of sinon is breaking the build 🚨 #134

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency sinon was updated from 7.2.4 to 7.2.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sinon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **ci/circleci: node-latest:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/756?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: node-8:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/755?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
Commits

The new version differs by 8 commits.

  • 8b8bddd Update docs/changelog.md and set new release id in docs/_config.yml
  • 33f0b67 Add release documentation for v7.2.5
  • 2b4bc7d 7.2.5
  • fb54e29 Update CHANGELOG.md and AUTHORS for new release
  • 8ac68f3 Upgrade mochify to latest
  • add43e3 Upgrade @sinonjs/samsam to latest
  • d0c073c don't call extends.nonEnum in spy.resetHistory (#1984)
  • f99e2ef Use stable Chrome in Circle

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 7.2.4 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 6 commits.

  • 0468cd4 Update docs/changelog.md and set new release id in docs/_config.yml
  • 7f2c8c2 Add release documentation for v7.2.6
  • 36b99b3 7.2.6
  • 1fc586e Update CHANGELOG.md and AUTHORS for new release
  • c8758fd Upgrade @sinonjs/formatio
  • e24daed Set fake.lastArg to last argument regardless of type

See the full diff

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 7 commits.

  • 4a8f432 Update docs/changelog.md and set new release id in docs/_config.yml
  • 714911e Add release documentation for v7.2.7
  • 33ca39b 7.2.7
  • e8b997f Update CHANGELOG.md and AUTHORS for new release
  • 7913865 Update @sinonjs/commons @sinonjs/formatio
  • 19b3fc7 Retain spy function names and fix spy.named(name) (#1987)
  • 3275d18 Document spying on accessors (#1976)

See the full diff