search

sfdx-isv / sfdx-falcon

A Salesforce CLI Plugin that enables and enhances implementation of the SFDX-Falcon family of projects, including the AppExchange Demo Kit (ADK) and AppExchange Package Kit (APK)
https://sfdx-isv.github.io/sfdx-falcon/
38 stars 6 forks source link

An in-range update of sinon is breaking the build 🚨 #140

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency sinon was updated from 7.2.7 to 7.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sinon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **ci/circleci: node-latest:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/877?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: node-8:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/878?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
Commits

The new version differs by 18 commits.

  • 059727b Update docs/changelog.md and set new release id in docs/_config.yml
  • e848851 Add release documentation for v7.3.0
  • fb55b11 7.3.0
  • b79a6ca Update CHANGELOG.md and AUTHORS for new release
  • c85fa66 Merge pull request #1999 from fatso83/fix-docker-headless-tests
  • 4b7a947 Simplify Circle CI setup
  • 3951eb7 Add a Docker Compose config file for testing the setup locally
  • 2119f08 Merge pull request #1994 from fatso83/expose-props-inject
  • 9faf58e Merge pull request #1997 from xeptore/patch-1
  • 0c7b2cd unnecessary things!
  • 20eeb48 Inject createStubInstance and fake functionality
  • 73d2ac8 Remove unused prop 'injectIntoThis'
  • fb5709f Fix #1974 by upgrading to @sinonjs/samsam@3.3.0
  • b8679fa Merge pull request #1989 from mgred/remove-deprecated
  • 617c40e chore: update @sinonsj/commons package

There are 18 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 7.2.7 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 5 years ago

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 6 commits.

  • 3812a7d Update docs/changelog.md and set new release id in docs/_config.yml
  • 93bef55 Add release documentation for v7.3.1
  • e02c192 7.3.1
  • 8ee1d35 Update CHANGELOG.md and AUTHORS for new release
  • bc53d82 Fix security issues
  • 1a09166 Update @sinonjs/samsam to v3.3.1

See the full diff