search

sfdx-isv / sfdx-falcon

A Salesforce CLI Plugin that enables and enhances implementation of the SFDX-Falcon family of projects, including the AppExchange Demo Kit (ADK) and AppExchange Package Kit (APK)
https://sfdx-isv.github.io/sfdx-falcon/
38 stars 6 forks source link

An in-range update of sinon is breaking the build 🚨 #151

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency sinon was updated from 7.3.1 to 7.3.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

sinon is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **ci/circleci: node-latest:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/976?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: node-8:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/sfdx-isv/sfdx-falcon/975?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
Commits

The new version differs by 6 commits.

  • 15a9d65 Update docs/changelog.md and set new release id in docs/_config.yml
  • 5d770e0 Add release documentation for v7.3.2
  • 585a1e9 7.3.2
  • b51901d Update CHANGELOG.md and AUTHORS for new release
  • 83861a7 Update Lolex to bring in fix for sinonjs/lolex#232
  • 2430fd9 Documentation (#2004)

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 7.3.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.