Segfault when enabling MQTT

[cmlpreston]

HI, I think I'm getting a segfault when MQTT is enabled.

The intHandler() is getting called at line 356 of sprinkler.c with a SEGFAULT signal. This only happens when I enable MQTT as follows:

10 # mqtt stuff (address and topic are mandatory if you want to use MQTT) 11 MQTT_ADDRESS = 192.168.1.19:1883 12 MQTT_USER = pi 13 MQTT_PASSWD = pi 14 MQT_TOPIC = sprinklerd

Any help appreciated. I'm happy to debug further.

[cmlpreston]

I've now narrowed the segfault to this line in publish_zone_mqtt()

sprintf(mqtt_msg, "%s", (digitalRead(gpiopin->pin) == gpiopin->on_state ? MQTT_ON : MQTT_OFF));

I'll investigate more later.

[cmlpreston]

I've switched to the WiringPi version. Works great!

[sfeakes]

Great piece of debugging. WiringPI has far more sanity checks than my GPIO implementation, but it's huge by comparison. Still be interested in why my GPIO implementation was crashing on your system. What version of OS and more importantly Board / SBC are you using?

[cmlpreston]

Hi, here's what sprinklerd reports for board id:

piBoardId: Revision string: Revision#011: a02082

and

$ uname -a Linux pi3 4.14.79-v7+ #1159 SMP Sun Nov 4 17:50:20 GMT 2018 armv7l GNU/Linux

and

$ cat /proc/device-tree/model Raspberry Pi 3 Model B Rev 1.2

HTH!

[sfeakes]

Thanks so much, think I am not reading your board as Pi3, and that’s what would cause the crash as I’m reading / writing to the wrong memory address for the GPIO. Can you please run ‘cat /proc/cpuinfo‘ and post the output. Thanks again.

[cmlpreston]

No problem. Here's the output.

$ cat /proc/cpuinfo processor : 0 model name : ARMv7 Processor rev 4 (v7l) BogoMIPS : 38.40 Features : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae evtstrm crc32 CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x0 CPU part : 0xd03 CPU revision : 4

processor : 1 model name : ARMv7 Processor rev 4 (v7l) BogoMIPS : 38.40 Features : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae evtstrm crc32 CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x0 CPU part : 0xd03 CPU revision : 4

processor : 2 model name : ARMv7 Processor rev 4 (v7l) BogoMIPS : 38.40 Features : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae evtstrm crc32 CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x0 CPU part : 0xd03 CPU revision : 4

processor : 3 model name : ARMv7 Processor rev 4 (v7l) BogoMIPS : 38.40 Features : half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32 lpae evtstrm crc32 CPU implementer : 0x41 CPU architecture: 7 CPU variant : 0x0 CPU part : 0xd03 CPU revision : 4

Hardware : BCM2835 Revision : a02082 Serial : 000000003567a948

[sfeakes]

I push an update, few small changes, not sure I fixed this, but if you could get the latest version and try the pre-built binary be interesting to know if it fixed it. I wouldn't overwrite your existing install just yet. So just to a git clone to a different/new directory, stop sprinklerd and run sudo ./release/sprinklerd -d -c <existing config file>

See if that works for you, if not, can you post the log. (please set debug mode)

Cheers

[cmlpreston]

(Deleted prior response, I forgot to uncomment the GPIO pin lines in the conf file first.)

Looks like its still crashing.

pi@pi3:~/Development/sprinkler/SprinklerD/release $ sudo ./sprinklerd -d -c /etc/sprinklerd.conf Debug: Config mqtt_topic 'sprinklerd' Debug: Config mqtt_dz_pub_topic '' Debug: Config mqtt_dz_sub_topic '' Info: Name = XXX Sprinklers Info: Port = 8080 Info: Docroot = /var/www/sprinklerd Debug: Found 2 ZONES Debug: No Information for ZONE = 0 Debug: ZONE = 1 Debug: Zone Config : Fence side PIN : 3 Set pull up/down : 0 ON state : 1 Domoticz IDX : -1 Debug: ZONE = 2 Debug: Zone Config : House side PIN : 2 Set pull up/down : 0 ON state : 1 Domoticz IDX : -1 Notice: Starting ./sprinklerd version 1.0e Debug: regexp no match (1) Debug: Read from cron Day 0 | Time 20:0 | Zone 1 | Runtime 15 Debug: Read from cron Day 0 | Time 20:15 | Zone 2 | Runtime 15 Debug: Read from cron Day 1 | Time 20:0 | Zone 1 | Runtime 15 Debug: Read from cron Day 1 | Time 20:15 | Zone 2 | Runtime 15 Debug: Read from cron Day 2 | Time 20:0 | Zone 1 | Runtime 15 Debug: Read from cron Day 2 | Time 20:15 | Zone 2 | Runtime 15 Debug: Read from cron Day 3 | Time 20:0 | Zone 1 | Runtime 15 Debug: Read from cron Day 3 | Time 20:15 | Zone 2 | Runtime 15 Debug: Read from cron Day 4 | Time 20:0 | Zone 1 | Runtime 15 Debug: Read from cron Day 4 | Time 20:15 | Zone 2 | Runtime 15 Debug: Read from cron Day 5 | Time 20:0 | Zone 1 | Runtime 15 Debug: Read from cron Day 5 | Time 20:15 | Zone 2 | Runtime 15 Debug: Read from cron Day 6 | Time 20:0 | Zone 1 | Runtime 15 Debug: Read from cron Day 6 | Time 20:15 | Zone 2 | Runtime 15 Debug: regexp no match (1) Debug: regexp no match (1) Debug: regexp no match (1) Debug: Read Calendar 'OFF' from cache Debug: Read delay24h 'OFF' from cache Debug: Read delay24h endtime '0' from cache Debug: Read Chance of Rain delay '0' from cache Debug: Read Rain 1d delay '0.000000'in from cache Debug: Read Rain 2d delay '0.000000'in from cache Debug: Read default_runtime '15' for zone 1 Debug: Read default_runtime '15' for zone 2 Debug: Running ./sprinklerd with options :- daemon=0, verbose=0, httpdport=8080, debug2file=0 configfile=/etc/sprinklerd.conf Debug: Setting up GPIO Debug: piBoardId: Revision string: Revision : a02082 Debug: piBoard Model: Pi 3 Debug: Setting up Zone 1 Debug: Set GPIO 3 to OUTPUT Debug: Setting up Zone 2 Debug: Set GPIO 2 to OUTPUT Debug: GPIO setup complete Debug: Starting HTTPD Notice: Starting web server on port 8080 Debug: MQTTaq 1 | MQTTdz 0 Debug: MQTTaq 1 | MQTTdz 0 Notice: Starting MQTT client to 192.168.1.19:1883 Info: Connected to mqtt 192.168.1.19:1883 with id of: sprinklerd_b827eb67a948 Info: MQTT: Subscribing to 'sprinklerd/#' Info: Stopping! Debug: Turning off Zone 1. Setting pin 3 to state 0 Debug: Turning off Zone 2. Setting pin 2 to state 0 Info: Wrote cache

[sfeakes]

Thanks so much for trying,

In your config, you have GPIO_PIN=3 GPIO_PIN=2

for your two zones. Just out of interest, when you have time, can you try different pins, eg GPIO_PIN=17 GPIO_PIN=18

Obviously the relays won't click over, but that's not important. I'd like to see if this is a memory address issue or some access issue. If same result, it's probably former, if works probably latter.

Thanks again for all your work.

[sfeakes]

BTW, I'm sure it will work if you uncomment #define GPIO_SYSFS_MODE in sd_GPIO.h, but you are better off using wiringPi than my GPIO implementation in sysfs mode. Well I say it will work, but you might get a different error as I haven't tested sysfs mode in a while...:)

[sfeakes]

Never mind, I can replicate the issue. I found a Pi same as yours, used your exact config and got the same error. Hope to post a fix soon.

[sfeakes]

Ok, fixed in version 1.0f

[cmlpreston]

Excellent, looks good to me too, although I'm at work and can't tell if the relays are operating! Do you recommend switching back to your GPIO code rather than WiringPi?

[sfeakes]

Switching back is up to you, it’ll save you having to compile each time you upgrade, but that’s about it. If you are using wiringpi for anything else on that particular pi or using some funky relay board that necessitates features of wiring pi, then I’d recommend keeping it compiled with wiring pi. I wrote my own GPIO simply to keep everything as small as possible and to save people the hassle of installing wiringpi and keeping 2 things up to date and compiled together. But speed / implementation wise they are identical.

When I get round to adding features for reading GPIO sensors & switches in the future, then I’d recommend using my implementation if you use want to use those.