search

sfeir-open-source / sonar-clover

It provides the ability to feed SonarQube with code coverage data coming from Atlassian Clover
Apache License 2.0
15 stars 25 forks source link

fix(Build): fix build using simple travis pipeline #21

Closed Tony-Proum closed 5 years ago

Tony-Proum commented 5 years ago

closes https://github.com/Tony-Proum/sonar-clover/issues/20

Tony-Proum commented 5 years ago

FYI https://community.sonarsource.com/t/plugin-copyright-ownership/3311 . For now, I'm not able to find a legal answer. I don't know if this is a good solution for now. Trying to get more helps with the company I work with.

mlschechter commented 5 years ago

Is there any reason to change the license? I'd recommend leaving it as GPL if it's simpler.

Tony-Proum commented 5 years ago

I thought about changing the licence to a more flexible one (MIT).This way, the company I work with should be able to helps and contribute easily. GPL seems a little bit restrictive for some users and so I think that it could be a thing that could block some contributions.

After all, I tried to find more informations about licensing and copyrights and it seems like that's an administrative burden and IMHO trying to be more flexible should helps the project to became more "open" and "active"

Tony-Proum commented 5 years ago

But I'm not sure that this is the good way to do, or if it's correct in legal or philosophical point of view... :sweat:

Tony-Proum commented 5 years ago

@ganncamp could you helps us to understand what's happen and why is this project copyrights had been reset ?

May be could you show us the right way to deal with this problem ?

ganncamp commented 5 years ago

@Tony-Proum I don't have enough context in this comment thread to understand what the problem is. What did you change, how did you change it, and when did it revert?

Tony-Proum commented 5 years ago

@ganncamp when I became owner of this project, all files came with this header :

/*
 * Sonar Clover Plugin
 * Copyright (C) 2008 ${owner}
  * sonarqube@googlegroups.com
...

see https://github.com/Tony-Proum/sonar-clover/commit/ea6c23eb9b3a6a5b09e4405f61f03fd52159d944 (@ganntest is it one of your test account @ganncamp ? :thinking: )

I tried to find the right way to contribute to this project so in my opinion, the first step to reach is to build the project properly. In order to do this, I had to update build tools and to fill the missing copyright informations. But even now, I'm not sure that it's a good think to appropriate those rights. is this commit designed to be way to abandon the copyright, or is it an un-achieved piece of work ?

ganncamp commented 5 years ago

In fact @Tony-Proum I (yes, that's my test account & making the commit with it was an accident) possibly shouldn't have made that change. In fact, I wish I had been more voluble in the commit comment (darn my previous self!) because I have no memory of the motivation or where I got the syntax. All I do know is that I didn't pull it out of the air or do it while sleepwalking.

IIWY, I'd revert that change & add a 2nd line: Copyright (C) 2018 @Tony-Proum. IANAL but my guess is that such a change would show both good faith and assert your ownership of any new changes.

Tony-Proum commented 5 years ago

@ganncamp Thank you for the explanation, I'll revert all unneeded changes I try to work this way.