search

sfeir-open-source / sonar-clover

It provides the ability to feed SonarQube with code coverage data coming from Atlassian Clover
Apache License 2.0
15 stars 25 forks source link

Find a directory to deploy our artifacts #24

Closed Tony-Proum closed 4 years ago

Tony-Proum commented 5 years ago

seems like something went wrong when uploading artifacts to repository see : https://travis-ci.org/Tony-Proum/sonar-clover/jobs/446242289

mlschechter commented 5 years ago

Looks like the enforcer plugin identified missing environment variables?

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-deploy-settings) @ sonar-clover-plugin ---
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireEnvironmentVariable failed with message:
Environment variable "ARTIFACTORY_URL" is required for this build.
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireEnvironmentVariable failed with message:
Environment variable "ARTIFACTORY_DEPLOY_REPO" is required for this build.
[WARNING] Rule 3: org.apache.maven.plugins.enforcer.RequireEnvironmentVariable failed with message:
Environment variable "ARTIFACTORY_DEPLOY_USERNAME" is required for this build.
[WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireEnvironmentVariable failed with message:
Environment variable "ARTIFACTORY_DEPLOY_PASSWORD" is required for this build.
Tony-Proum commented 5 years ago

We should be able to have an Artifactory account for this project. I'm on it

heruan commented 5 years ago

Any progress on this?

Tony-Proum commented 5 years ago

I'm working with jfrog tools and team in order to see which type of account should be use. Also, this repository will be transferred under an organization that I would like to work with (As it should help me to have more time to work on this project and sould help to get more devs involve in the project. It should allows the plugin to evolve faster)

Tony-Proum commented 5 years ago

FYI an oss artifactory/bintray account may be use to store our artifacts.

Tony-Proum commented 5 years ago

(Sorry for the delay: my son was born few days ago and I can't sleep a lot for the moment :smile: )

heruan commented 5 years ago

Not sure I'm following: won't this be available in Maven Central?

Tony-Proum commented 5 years ago

The build tools used for this plugin is the same as the official plugins supported by sonarSource so we should not have any issue to use it in a clean SonarQube install. Also I don't know how it works for other plugins (maven central or directly jfrog jcenter) but using Jcenter, it still be possible to upload artifacts on maven central.

mlschechter commented 5 years ago

@Tony-Proum.

I'll have some time next week to help out if you've got some tasks I can work on. Also, I'm going to look at removing the deprecated XML-handling code so that the new version will be completely clean and compatible with SQ 7.2+

seenusankara commented 5 years ago

@mlschechter , can I have the release date for the new version which is supported for SonarQube 7.4 or 7.2

mlschechter commented 5 years ago

@seenusankara,

I've updated my pull request to remove the deprecated code, and verified it works against 7.4 (sort of - as of 7.2 the Groovy plugin is no longer supported, so the Groovy-based integration test fails).

@Tony-Proum can provide more input on a release schedule; it looks like there are still some issues to be resolved before my code can be merged.

cesares-basilico commented 5 years ago

@Tony-Proum any news about the release of the fixed plugin? Can you please push the changes so we can build it locally while you find a directory to deploy?

Tony-Proum commented 5 years ago

I'll transfer this repository to a new organization in order to provide a better support. The organization could help to update the plugin faster. I've not been able to do It before, but this transfer should happen soon, this way more people should be able to contribute.

heruan commented 5 years ago

Any update?

Tony-Proum commented 5 years ago

Hello @heruan, the plugin has been transferred to the organization. We are not able to build it and to deal with the licence. Also we're now able to get some quality analysis using sonarCloud plateform (AFAIK it's mandatory to create a plugin that's allowed to be published in the sonarQube market place) you can see the result here https://sonarcloud.io/dashboard?id=sfeir-open-source_sonar-clover In order to go further, we have to link the organization with an artifact repository, for now, I'm trying to have more informations about this topic, I'll keep you inform

Tony-Proum commented 4 years ago

FYI, now our artifacts can be uploade to Jfrog Bintray, all checks are ok. We are now trying to fix some issue to integrate the plugin with the market place but this issue is now fixed