fix: Groovy compatibility

sfeir-open-source / sonar-clover

It provides the ability to feed SonarQube with code coverage data coming from Atlassian Clover

Apache License 2.0

15 stars 25 forks source link

fix: Groovy compatibility #45

Closed prestontim closed 3 years ago

prestontim commented 3 years ago

Fix for issue reported here: https://community.sonarsource.com/t/clover-coverage-analysis-sensor-not-firing-on-groovy-projects/35364

Tested manually on a SonarQube instance.

CLAassistant commented 3 years ago

All committers have signed the CLA.

prestontim commented 3 years ago

@Tony-Proum Is there a chance that this can get merged/released? Thanks in advance.

johorta commented 3 years ago

What is missing to generate a release of this fix?

sbglasius commented 3 years ago

If this requires monetary contribution to review and merge I suggest applying to https://opencollective.com/friends-of-groovy

The community is awaiting your response.

Thank you.

sbglasius commented 3 years ago

@prestontim Please review and accept :)

prestontim commented 3 years ago

@sbglasius I would love to see this merged, but I don't have write access to this repo.

sbglasius commented 3 years ago

@sbglasius I would love to see this merged, but I don't have write access to this repo.

Can you point to one who does? As said, if it is downplayed because of monetary reasons, that can probably be dealt with.

prestontim commented 3 years ago

@sbglasius I don't have any first-hand knowledge about this repo, but I am assuming that one of the contributors can merge this. How to get in touch with any of them? Your guess is as good as mine.

jespersm commented 3 years ago

@Tony-Proum: Could you review and merge this PR?

prestontim commented 3 years ago

Could someone please merge and release this fix?

cc: @geromegrignon @kuroidoruido @rlespinasse @Shikanime @tinesoft

geromegrignon commented 3 years ago

@prestontim Thanks for this contribution. I'm not competent to review your PR and release a new version but will make sure someone does as soon as possible.

Tony-Proum commented 3 years ago

Oh sorry, I totally missed the notifications. We have to migrate our artifact repository prior to include this change in the future release (we are using Bintray for now, but well, I' ll push merge this into master branch and try to find time to migrate into another artifact repository and release the plugin as soon as possible)

Tony-Proum commented 3 years ago

@prestontim Is it possible to add a simple example of a groovy project in order to create a integration test case ? (something like the one you can fin here: https://github.com/sfeir-open-source/sonar-clover/tree/master/its/integration (a simple hello world is sufficient)

andersaaberg commented 3 years ago

@Tony-Proum : I have made a pull request with a simple groovy project if that is sufficient: https://github.com/sfeir-open-source/sonar-clover/pull/46

Tony-Proum commented 3 years ago

As mentioned in thoes two issues, this fix seems not to do anything with groovy projects . I'll we try to help providing a doc on how I test it locally in few times.