search

sfeir-open-source / talk-control

This project aims to make speakers' life easier by supplying an app to remotely control their slideshow.
Apache License 2.0
2 stars 5 forks source link

fix: current slide height #107

Closed GildasMorel closed 4 years ago

GildasMorel commented 4 years ago

Fix the height of the on stage view, to avoid small scrolling when hitting page down to go to next slide.

jtanguy commented 4 years ago

Is this a duplicate of #104 ? I was working on it, and had a different resolution

GildasMorel commented 4 years ago

It's the PR for the #104

What's your solution?

Le mar. 13 oct. 2020 à 16:54, Julien Tanguy notifications@github.com a écrit :

Is this a duplicate of #104 https://github.com/sfeir-open-source/talk-control/issues/104 ? I was working on it, and had a different resolution

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/sfeir-open-source/talk-control/pull/107#issuecomment-707796101, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMDYEDZFC6KNHJAPX7RI5P3SKRS23ANCNFSM4SO63NGA .

jtanguy commented 4 years ago

I had a solution more based on css, but yours is shorter. Anyway, I have some general improvements that will go in a different PR