search

sfeir-open-source / talk-control

This project aims to make speakers' life easier by supplying an app to remotely control their slideshow.
Apache License 2.0
2 stars 5 forks source link

4 registerPlugin events triggered #70

Open GildasMorel opened 4 years ago

GildasMorel commented 4 years ago

In talk-control-slave, in :

this.eventBusSlave.on(MASTER_SLAVE_CHANNEL, 'registerPlugin', ({ pluginName }) => {

Add :

if (pluginName === 'touchPointerInput') {
    console.log('slave => registerPlugin', pluginName, this.shadowRoot);
}

For layout stage view, there are 4 of thoses events triggered, but it should be only 2 : reveal engine talk control slave and slide-view talk control slave.

Why ?

GildasMorel commented 4 years ago

This bug causes the zooming behavior with dlbclick to not work on branch feat/61-handle-input-generators-as-plugins

GildasMorel commented 4 years ago

Found! We must not call super.init() in components slaves (like slide-view-slave.js)