search

sfelix-martins / passport-multiauth

Add support to multi-authentication to Laravel Passport
MIT License
288 stars 51 forks source link

Utilize Symfonys PSR Factory #126

Closed kristianheljas closed 4 years ago

kristianheljas commented 4 years ago

This PR addresses https://github.com/sfelix-martins/passport-multiauth/issues/124

Laravel passport version 8.4.1 bumped symfony/psr-http-message-bridge to version 2 thus removing DiactorosFactory. Laravel Framework also recommends version 2 since v7.0.0

This pull request is copy-paste from Laravel Framework pull request which is keeping backwards compatibility the same.

Tested with Laravel Framework 7.3.0 + Laravel Passport v8.4.3.

kristianheljas commented 4 years ago

Got Travis to pass all checks as well, final candidate for now

juhasev commented 4 years ago

Nice work maybe we get @sfelix-martins could merge this in! The previous PR didn't pass the tests so this is looking really good!

sfelix-martins commented 4 years ago

@kristianheljas Thanks for you PR, please change the PR base branch to 7.x. Check it if necessary.

kristianheljas commented 4 years ago

Happy to contribute @sfelix-martins, glad to see such fast response!

juhasev commented 4 years ago

Awesome! Can we get release for the 7.x branch please! @sfelix-martins I can't wait to test this out.