Twitter::Client#blank? conflicts with rails #blank? and #present?

sferik / twitter-ruby

A Ruby interface to the Twitter API.

http://www.rubydoc.info/gems/twitter

MIT License

4.58k stars 1.31k forks source link

Twitter::Client#blank? conflicts with rails #blank? and #present? #960

Closed matteeyah closed 4 years ago

matteeyah commented 5 years ago

Twitter::Client#blank? conflicts with the usage of rails #blank? and #present?.

It should be renamed to something else that's ambiguous and not used in rails.

sferik commented 4 years ago

What’s the actual issue here? This is a private method, so it shouldn’t conflict.

matteeyah commented 4 years ago

I wish I explained this better at the time of opening. I can't seem to remember what it conflicted with exactly, but I'm 100% positive that it somehow had a negative impact to the usability of this gem (otherwise I wouldn't have opened it).