search

sferik / x-ruby

A Ruby interface to the X API.
MIT License
68 stars 13 forks source link

Return the status when the upload fail #19

Closed GCorbel closed 5 months ago

GCorbel commented 5 months ago

This fix https://github.com/sferik/x-ruby/issues/18

When the upload of a file fail, there was an infinite loop. This PR fix the issue.

sferik commented 5 months ago

Thanks so much for your patch! For your information, I just made this small performance enhancement to prevent garbage from being created on each iteration of the loop: https://github.com/sferik/x-ruby/commit/0b13729cd1ad6d1001a55dc6d47fa7aaf6bd0566