sfg-taxonpages / orthoptera

0 stars 0 forks source link

missing pic #65

Closed klausriede closed 6 months ago

klausriede commented 6 months ago

the picture for Heteracris herbacea (available in old OSF) http://orthoptera.archive.speciesfile.org/Common/basic/Taxa.aspx?TaxonNameID=1113836 is missing! https://orthoptera.speciesfile.org/otus/929688/overview

typophyllum commented 6 months ago

imagen

If you access the species from the descendents the pictures are there. The search seems to pick up a different OTU.

typophyllum commented 6 months ago

I deleted the duplicate OTU (929688). But this is a general problem I already noticed several times.

klausriede commented 6 months ago

@mjy @LocoDelAssembly should not be too difficult to write a query/routine [younameit] to detect duplicate OTUs - in fact individual OTUs should be unique?

klausriede commented 6 months ago

so what is Acrida herbacea https://orthoptera.speciesfile.org/otus/818025/overview ?

typophyllum commented 6 months ago

Acrida herbacea is a different species (n. sp. in Bolívar 1922) with different type locality.

LocoDelAssembly commented 6 months ago

@typophyllum when you deleted the duplicate was it after making sure the OTU did not have any data that the corresponding OTU didn't have?

LocoDelAssembly commented 6 months ago

As for detecting duplicates, we have multiple OTUs with same taxon name but they differ in that the duplicates have Otu.name set (which is not a taxon name, is kind of label for OTU). To list the duplicates Filter OTU with option With Name set to With returns the list, about 4100 OTUs.

typophyllum commented 6 months ago

Yes, I made sure that the other OTU didn't have anything that the remaining 820712 doesn't have.

Does this mean that there are 4100 names where the search presents a duplicate and then the pictures might be missing on the taxon page?

mjy commented 6 months ago

What TaxonName was the original OTU that you destroyed linked to? OTUs that are linked to synomous TaxonNames should still have their data appear on the TaxonPages, as they are "coordinate" in our sense. If they don't then there is likely a bug.

LocoDelAssembly commented 6 months ago

On next TW release it will not be possible to find these duplicate OTUs in OSF: https://github.com/SpeciesFileGroup/taxonworks/commit/56226490eaa73da8f8363256c882d83a8aec9ba6

typophyllum commented 6 months ago

I think it was the same situation like in the sandcastle: imagen The OTU with both incorrect protonym and current combination has been destroyed. Strangley, on its page it did show the three pictures that were missing in TP.