File Naming Reformatting

sfhelmet / InterestFreeCondos

0 stars 1 forks source link

Closed DanielC2001 closed 6 months ago

DanielC2001 commented 6 months ago

Reformatted file names to new convention.
Root folders under src will be in snake case
Everything under each root folder e.g src/pages/ will use PascalCase so: src/pages/HomePage for example

wam82 commented 6 months ago

@DanielC2001 can you check why the Node.js is failing? Once resolved will approve. I don't want to approve something that fails the checks :/

wam82 commented 6 months ago

I'm assuming the files that are considered new by git are because the files were relocated and not actually code duplication right? @DanielC2001

wam82 commented 6 months ago

All checks have passed waiting on Daniel's replies to make sure everything is in order before approving.

DanielC2001 commented 6 months ago

I'm assuming the files that are considered new by git are because the files were relocated and not actually code duplication right? @DanielC2001

Fixed it, seems like git auto ignore case for file names by default. Github still auto capitalizes for some reason but we'll fix it if need be

DanielC2001 commented 6 months ago

All checks have passed waiting on Daniel's replies to make sure everything is in order before approving.

All done!

wam82 commented 6 months ago

Alright sounds good. All files were reviewed and looks fine other than the mentionned comments