search

sfiorini / NordVPN-Wireguard

A bash scripts that generates Wireguard configuration file for a NordVPN connection.
229 stars 40 forks source link

Simplification to the script.... #3

Closed freefly42 closed 4 months ago

freefly42 commented 2 years ago

You'd asked for a pull request, I guess I thought it would be fun to make one!

I updated the readme as this does significantly change how the script works, but creates a lot of flexibility by simply passing on arguments to nordvpn connect....

sfiorini commented 2 years ago

@freefly42 , thank you. Please give me till the weekend to test it and then merge your code as I am quite busy with work at the moment. Again, I truly appreciate your help in making this script better.

sfiorini commented 2 years ago

@freefly42, Tested and found the following issues:

  1. Error: "flag provided but not defined: -g"
  2. Help flag returns the help of "nordvpn" command instead of help for the utility.
  3. New code does not create unique file configuration names based on the city/country selected.
sfiorini commented 4 months ago

I have added a slightly modified version your code to version 0.2.0. Thank you so much for your help.