search

sfirke / janitor

simple tools for data cleaning in R
http://sfirke.github.io/janitor/
Other
1.38k stars 132 forks source link

Run lintr and styler to format code #172

Closed sfirke closed 6 years ago

sfirke commented 6 years ago

http://style.tidyverse.org/

sfirke commented 6 years ago

Well, styler will make massive changes to my formatting. It may be a slight improvement, but one consequence is that I should close out the tidyeval PR first, b/c changing the whitespace will make the diff that much noisier.

sfirke commented 6 years ago

I ran styler.

sfirke commented 6 years ago

I ran lintr::lint_package() and also goodpractice::gp(). lintr doesn't like code in comments and lines over 80 characters... well, tough winkies b/c I have hundreds of lines like that and it's totally not worth the time to truncate them. I'll try to do better going forward.

Made a few fairly trivial but technically-correct changes, will merge in and move on. Good to know there wasn't anything of consequence lurking.