search

sfirke / packagemetrics

A Package for Helping You Choose Which Package to Use
Other
134 stars 6 forks source link

Installation #15

Closed HenrikBengtsson closed 7 years ago

HenrikBengtsson commented 7 years ago

Drive-by note: missing 

Remotes: thierrygosselin/stackr

in DESCRIPTION

ledell commented 7 years ago

Also wondering if R 3.4.0 is a necessary requirement, or can it be relaxed to an earlier version of R?

sfirke commented 7 years ago

Thanks both! @HenrikBengtsson I added a dependency on https://github.com/lshep/stackr, and @ledell I backed it down to require R 3.3.0 ... do you think that's sufficient or should I try to go back further?

bzkrouse commented 7 years ago

Agreed, thank you!

@sfirke & @ledell - unfortunately, since we're utilizing tools::CRAN_package_db() (a function that's new to 3.4.0), I don't think we have flexibility in the dependency at the moment. Maybe we should consider scraping the info directly from CRAN instead.

sfirke commented 7 years ago

Whoops good catch, I'll revert that part

On May 28, 2017 9:38 PM, "Becca Krouse" notifications@github.com wrote:

Agreed, thank you!

@sfirke https://github.com/sfirke & @ledell https://github.com/ledell - we're utilizing tools::CRAN_package_db(), a function that's new to 3.4.0, so I don't think we have flexibility in the dependency.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ropenscilabs/packagemetrics/issues/15#issuecomment-304555126, or mute the thread https://github.com/notifications/unsubscribe-auth/AHOBkHpHzSAQgAEZwdmSpXFc-F5XqSrmks5r-iGQgaJpZM4NoMK6 .

ledell commented 7 years ago

Thanks @bzkrouse and @sfirke. Time for me to upgrade to 3.4.0!