search

sfirke / packagemetrics

A Package for Helping You Choose Which Package to Use
Other
134 stars 6 forks source link

Fix vignette indicator #25

Closed treysp closed 7 years ago

treysp commented 7 years ago

Hello,

Really like the package - great work!

In cran_metrics(), the has_vignette_build field is currently assigned TRUE if the field is NA. But if it's NA, that means that there is not a vignette, so the ifelse() return values are switched.

This PR fixes that, along with a typo in the cran_metrics() documentation.

Best, Trey

sfirke commented 7 years ago

Good catch, thanks for this PR Trey!