search

sflpro / notifier

The notifications microservice is an independently deployable component intended for sending various types of notifications.
Apache License 2.0
47 stars 13 forks source link

Adding an index on notifier_properties #158

Closed dnavre closed 3 years ago

dnavre commented 3 years ago

I changed the approach used in flyway script naming. when reviewing please pay particular attention to that.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_151) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11. Read more here

dnavre commented 3 years ago

Please create alternative idx also for MySQL

I think that probably won't be required cause it creates indexes for FKs automatically.

dnavre commented 3 years ago

Flyway refuses to apply validation, please use the projects versioning model, instead of logically correct one :)

Validate failed: Detected resolved migration not applied to database: 1.10.1

done :) Sorry for the hassle.