DataBroker buttons not being included

sfmict / HidingBar

Adds a custom panel for easy add-on management.

GNU General Public License v3.0

8 stars 1 forks source link

DataBroker buttons not being included #17

Closed kemayo closed 2 years ago

kemayo commented 2 years ago

Environment

Addon version: v10.0.0
WoW version: 10.0.0.46313

Expected Behaviour

All DataBroker plugins would be present in the HidingBar configuration.

Actual Behaviour

Some LDB plugins were included, but most weren't.

Debug Output

No errors occurred.

Screenshots

sfmict commented 2 years ago

Hello, why do you think this is wrong behavior? The addon only takes objects with the "launcher" type, and rightly so. If developer doesn't want to add a button for other addons, i won't.

kemayo commented 2 years ago

Many data source broker plugins also function as a launcher if you click the icon, or are only intending to show a tooltip rather than any sort of label (and the spec only guarantees OnTooltipShow for data source) -- so even if it's (quite reasonably) missing the text display, it'd still be very useful to get the icon+tooltip.

sfmict commented 2 years ago

Yes, "data source" is used for most minimap buttons, etc., but if the author wanted to add it, he would. I'm not sure if this needs to be added.

kemayo commented 2 years ago

Could make sense to have it as another category in the "options of adding buttons" section, maybe? I'd understand it being a disabled-by-default setting, but I know I'd always turn it on (and then maybe situationally-disable some actual label-only brokers, I'm sure).

sfmict commented 2 years ago

Maybe, i should see how it works.

sfmict commented 2 years ago

Added option, check

kemayo commented 2 years ago

Nice! That seems to work very well for my purposes. Thanks for adding it.