search

sfmict / MountsJournal-ElvUI-Skin

This addon reskins the MountsJournal addon for ElvUI.
GNU General Public License v3.0
1 stars 1 forks source link

HandleTab being misused causes errors in ElvUI plugins #3

Closed eltreum0 closed 1 month ago

eltreum0 commented 1 month ago

As mentioned on the PR, the proper use of the HandleTab from Skins module of ElvUI is to send the parent tab into the function, which will then skin its children

But right now the .selected element of the tab is being sent instead, this causes other addons and plugins to throw errors because the .selected element is not the actual tab and lacks the OnClick function, if you swap to HandleTab(tab) the error will stop and the tab will be properly skinned by ElvUI

sfmict commented 1 month ago

This is not a default tab, so I created the style myself. If you want something different, you can do it yourself. HandleTab don't touch OnClick.

sfmict commented 1 month ago

HandleTab has been removed :)