search

sfodje / perlcritic

MIT License
5 stars 4 forks source link

feat: support giving a full path to executable #27

Closed alexgarel closed 2 years ago

alexgarel commented 2 years ago

fixes: #26

alexgarel commented 2 years ago

@sfodje I also run the validateExecutable lately because as the code was, I wasn't able to see the error, as connection.window.showErrorMessage in validateExecutable was called before connection was ready, leading to a crash of the extension, without any mean to understand what was causing that.

sfodje commented 2 years ago

Change looks good. Should be available with the 1.3.8 release.

alexgarel commented 2 years ago

thanks @sfodje