sfomuseum / accession-numbers

Machine-readable regular expressions for identifying accession numbers for cultural heritage organizations in text.
Other
6 stars 3 forks source link

Account for language in "object_url" property #43

Open straup opened 2 years ago

straup commented 2 years ago

For example, the definition file for the Rijksmuseum assumes that the object_url property will point to the English-language version of their website:

    "object_url": "https://www.rijksmuseum.nl/en/collection/{accession_number}",    

Those kinds of assumptions shouldn't be... well, assumed. This might mean redefining the object_url property to be a dictionary along the lines of:

"object_url": {
   "en": "https://www.rijksmuseum.nl/en/collection/{accession_number}",
   "fr": "https://www.rijksmuseum.nl/fr/collection/{accession_number}"
}

Or maybe just changing the software packages that expand URI templates to take a dictionary of values (to expand) rather than a single (accession_number) value.

The latter approach feels more-better to me, as I write this. TBD...

thisisaaronland commented 2 years ago

The corollary to this is that it makes sense to include a list of supported languages for a website in an organization's definition file so ultimately it may make sense to use a dictionary in object_url. I guess it depends on whether or not similar language qualifiers need to be applied elsewhere (IIIF manifests, perhaps?)