search

sfomuseum / accession-numbers

Machine-readable regular expressions for identifying accession numbers for cultural heritage organizations in text.
Other
6 stars 3 forks source link

Added V&A accession numbers patterns #50

Closed sheharbano96 closed 2 years ago

sheharbano96 commented 2 years ago

We'd like to contribute the V&A accession number patterns to the project. We've executed the test-runner on the json and it has passed all the tests.

thisisaaronland commented 2 years ago

Thanks!

I see that there are (3) different patterns but each has the same label (common). Would you assign each their own individual descriptive labels, please?

sheharbano96 commented 2 years ago

No problem. I just updated the labels. I hope it's alright now.

thisisaaronland commented 2 years ago

Thanks again! The definition file should be vam.ac.uk.json (definition files correspond to the principal domain for an institution) but I will change that after the fact.

sheharbano96 commented 2 years ago

Thanks, Appreciate it!