search

sframe-wg / sframe

Internet draft for SFrame
Other
7 stars 10 forks source link

Inconsistent test vector formatting #161

Closed chris-wood closed 12 months ago

chris-wood commented 12 months ago

Some hex strings in the test vectors are 0x-prefixed, whereas others are not. For ease of testing, these should be made consistent.

bifurcation commented 12 months ago

They are already consistent:

All values are either numeric or byte strings. Numeric values are represented as hex values, prefixed with 0x. Byte strings are represented in hex encoding.

chris-wood commented 12 months ago

@bifurcation But why have this prefix at all? In my implementation I had to strip off the prefix manually to parse the numbers, which just seems like something we could avoid.

bifurcation commented 12 months ago

Why are you parsing the RFC for your implementation? There's a JSON file in the repo which has the numbers already as numbers.