search

sframe-wg / sframe

Internet draft for SFrame
Other
7 stars 10 forks source link

derive_key_salt HKDF hash function #164

Closed chris-wood closed 12 months ago

chris-wood commented 12 months ago

The hash function to use with HKDF in derive_key_salt is currently unspecified. Presumably it's the hash function associated with the cipher suite, but let's make that explicitly clear.

bifurcation commented 12 months ago

Huh, I thought that was pretty obvious. (Where else would the hash come from?) Happy to consider a PR if you think there's a way to be clearer.

chris-wood commented 12 months ago

I agree that it's mostly obvious, but when I read it I did ask myself the question. I figure it's easier to just be explicit here.

chris-wood commented 12 months ago

Oh, hah, there's already a line that says what it should be! 

The hash function used for HKDF is determined by the cipher suite in use.

I just didn't read the entire section. Closing.