search

sfsam / Itsycal

Itsycal is a tiny calendar for your Mac's menu bar. http://www.mowglii.com/itsycal
MIT License
3.26k stars 234 forks source link

Fix Big Sur issues #170

Closed pakerwreah closed 3 years ago

pakerwreah commented 3 years ago

Fix toolbar glitch on Big Sur

prefs-toolbar

Fix event table not occupying full width on Big Sur

event-table-width

Fix random zoom icon alignment

zoom-icon-alignment
sfsam commented 3 years ago

I appreciate this. I'm currently still building on Mojave so I don't encounter the toolbar and tableview glitches yet. But I will likely move to Big Sur in the future so the style changes are helpful. I believe there is another one in the General Prefs tableview. Could you add that to this PR since it is the same fix? I'm a little nervous about changing to a stack view since I'm not familiar with it. Could you try just setting the content hugging priority on the duration grid view and see if that works?

_durationGrid = [NSGridView gridViewWithViews:@[@[_durationTextField, _btnVideo]]];
_durationGrid.rowSpacing = 0;
[_durationGrid setContentHuggingPriority:999 forOrientation:NSLayoutConstraintOrientationHorizontal];
pakerwreah commented 3 years ago

lol... I tried setting the HuggingPriority on the cells (which doesn't work) but not on the grid itself. Your suggestion worked, I'm gonna fix the prefs table and update the PR.