sfstar / hass-victron

Integration for Home Assistant to fetch data from the victron gx device via modbusTCP
Apache License 2.0
178 stars 26 forks source link

Fixing depricated constants in HA 2024.1 #155

Closed ChristophCaina closed 7 months ago

ChristophCaina commented 9 months ago

this should address issue #154

please run some tests before merging, since I do not have any victron installed so far and therefore cannot do tests,

ChristophCaina commented 9 months ago

.

thanks... I've changed it just to be sure. Don't understand, why this has been implemented in a second import of the constants and is never used in the code here... anyway :)... thanks for pointing it out

blauerreiter commented 9 months ago

HA now starts without warnings

iot-werkstatt commented 8 months ago

I just replaced the 3 files and can confirm that after restarting HA no more errors are showing up. Great job. Thanks.

sfstar commented 7 months ago

Based on a quick review of the changes and the supporting tests done by @blauerreiter and @iot-werkstatt i'm gonna merge and release these changes as a patch release. Thanks for contributing :)