search

sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
97 stars 39 forks source link

Direction of line source as Green's function #122

Open hagenw opened 7 years ago

hagenw commented 7 years ago

In driving_function_imp_wfs_ls() the line source has an orientation in the 3D case, which is provided by the user. In greens_function_imp() this is not the case for the line source, see line 97. Should we include this there, too?

trettberg commented 7 years ago

Same thing with driving_function_mono_wfs_ls() and greens_function_mono().

It would be nice to do this in a consistent way, but there will be some difficulties:

With the driving functions, xs(3:6) indicates orientation of the virtual line source. For secondary sources on the other hand, x0(3:6) is needed for direction.

For the moment I think we should leave it as it is.

hagenw commented 7 years ago

That's true, but at least both driving functions and both Green's functions are consistent at the moment.

It's also ok for me to stay with this for the moment. If someone really needs this functionality she/he could change it then.