sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
96 stars 39 forks source link

Delayline section in SFS_config.m #163

Closed hagenw closed 6 years ago

hagenw commented 7 years ago

The delayline section config section in SFS_config.m is difficult to understand if you are not an expert in this area. For example, it is not clear what might be a good setting for fractional delays. Is this done with purpose, because it heavily depends on the application. Or is it save to add a comment indicating a good default fractional delay setting?

In addition, I was wondering if it would help to move the conf.delayline.filter section to the beginning of the delayline section?

fietew commented 7 years ago

The delayline section config section in SFS_config.m is difficult to understand if you are not an expert in this area. For example, it is not clear what might be a good setting for fractional delays. Is this done with purpose, because it heavily depends on the application. Or is it save to add a comment indicating a good default fractional delay setting?

I could add the settings, which I usually use, when I want to be sure, that the fractional delay interpolation has no influence on the simulation result. The simulation will be rather slow, but it might be the best solution, if you don't have a clue, what to choose. One could also cite the paper https://doi.org/10.1109/EUSIPCO.2016.7760682 to show, that the necessary interpolation accuracy highly depends on the actual use case and parametrisation.

In addition, I was wondering if it would help to move the conf.delayline.filter section to the beginning of the delayline section?

Yes, good idea.

hagenw commented 6 years ago

Done.