sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
96 stars 39 forks source link

Change default 2.5D WFS fs driving function #168

Closed hagenw closed 6 years ago

hagenw commented 6 years ago

This is a follow up on #146 which introduced a fix for the 2.5D reference scheme in 2.5D as the current default implementation has the problem of possible division by 0. The resulting problems can be seen by running test_localwfs_vss(1) or by executing the example provided in #146.

As the proposed solution of a reference circle includes the point solution, which is currently implemented with conf.xref it should be ok to switch the default to this, even if the documentation is not up to date with it and we will have a new referencing scheme in 2.5 anyhow, see #136.

@fietew: if you agree with this, please "rebase and merge". If it would include more work, I would propose to postpone it also to the release 2.5.