Closed fietew closed 6 years ago
Nice addition, could you add two logarithmic example to test_secondary_source_positions()
, one with conf.secondary_sources.logspread
< 1 and one with > 1. This would be cool.
Regarding the usage of conf.secondary_sources.grid
, I think that it should be sufficient to use only conf.secondary_source.logspread
and have a default value of 1
. If you are planing to add more grid spacings for a linear array then it would make sense to use conf.secondary_sources.grid
, but otherwise it would add the burden of using two config settings to change one thing.
Try:
I am still not sure, how to handle the new functionality in the
conf
struct: In principle, both logarithmic and equi-distant sampling could be handled usingconf.secondary_source.logspread
, since1.0
would results in an equi-distant spacing. Should we nevertheless useconf.secondary_sources.grid
in addition?