search

sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
96 stars 39 forks source link

fix bug in LWFS-SBL, where inverse Allpass was inverted, again #183

Closed fietew closed 6 years ago

hagenw commented 6 years ago

Is this visible in one of our tests? If not could you provide a small example to highlight the differences?

fietew commented 6 years ago

You can see a difference of the phase in the monochromatic plots of test_localwfs_sbl for a virtual point source. However, the ground truth is not visible. 

SFS_start;
conf = SFS_config;
conf.plot.useplot = false;

f = 1000;

xs = [2.5, 0, 0];

X = [-1.25,1.25];
Y = 0;
Z = 0;

Pgt = sound_field_mono_point_source(X,Y,Z,xs,f,conf);
[P, x] = sound_field_mono_localwfs_sbl(X,Y,Z,xs,'ps',f,conf);

figure;
plot(x,real(Pgt),x,real(P));
legend('ground truth', 'LWFS-SBL');
title('point source at x=2.5 m');

Result for b8eeceb (master):

master

Result for 6915b0e (fix):

fix