sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
96 stars 39 forks source link

Test interpolation methods fails under Octave #190

Closed hagenw closed 5 years ago

hagenw commented 5 years ago

Running the test_interpolation_methods(1) in the ´validation/` folder fails for the last two plots.

The first issue is the non-supported legend option 'Location','SW'.

By removing this option Octave continues and shows the figures, but they contain only the legend and the following warning message is returned:

warning: axis: omitting non-positive data in log plot
warning: axis: omitting non-positive data in log plot
warning: axis: omitting non-positive data in log plot
warning: axis: omitting non-positive data in log plot
warning: axis: omitting non-positive data in log plot
warning: axis: omitting non-positive data in log plot
warning: opengl_renderer: data values greater than float capacity.  (1) Scale data, or (2) Use gnuplot
fietew commented 5 years ago

For the location of the legend https://github.com/sfstoolbox/sfs-matlab/blob/67d20342d2366c2ea1993d1f23397056f03d7cd6/validation/test_interpolation_methods.m#L250-L251 a compatible value would be 'southwest'

The warnings are related to https://github.com/sfstoolbox/sfs-matlab/blob/67d20342d2366c2ea1993d1f23397056f03d7cd6/validation/test_interpolation_methods.m#L239-L246 The semilogx does not allow f == 0.

hagenw commented 5 years ago

Thanks. To get warnings is not a problem, but the plot is also empty. Is this as well related to f == 0?

fietew commented 5 years ago

I will quickly provide a PR for this.

fietew commented 5 years ago

Thanks. To get warnings is not a problem, but the plot is also empty. Is this as well related to f == 0?

Yes

fietew commented 5 years ago

See #191

hagenw commented 5 years ago

Solved by #191