sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
98 stars 39 forks source link

Have a look at several TODOs regarding localsfs #25

Closed hagenw closed 9 years ago

hagenw commented 9 years ago

I have added several TODO messages in the text of some of the new localsfs functions and the SFS_config_example.m file. Could have a look at those and add the corresponding stuff to it.

fietew commented 9 years ago

Just in general: Is there a way in github to link these issues to specifc commits? Because now I had to look up all your commits and search for the TODOs.

fietew commented 9 years ago

However, I added the missing stuff for the TODOs I found.

hagenw commented 9 years ago

You just have to write the write the SHA of a commit and it will become a link, see: https://help.github.com/articles/writing-on-github/#references

But what I do to search for TODOs is the following:

cd repo_root
grep -R 'TODO' *
hagenw commented 9 years ago

Only one is missing now: https://github.com/sfstoolbox/sfs/blob/localsfs/SFS_time_domain/driving_functions_imp/driving_function_imp_wfs_vss.m#L75

fietew commented 9 years ago

Solved with a333ef690952686c4c17a1449372d402f0ef647c