search

sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
98 stars 39 forks source link

WFS IIR prefilter #29

Closed hagenw closed 8 years ago

hagenw commented 9 years ago

By executing the test function for the IIR pre-filter from current master (bdd0e4a0c6a31f22f6cdb2a3f6d73168fcdfd1b0) in Matlab R2013a

>> test_wfs_iir_prefilter

I got the following error:

Error using fdesign.arbmag/set
There is no enumerated value named 'Nb,Na,F,A'.

Error in /usr/local/MATLAB/R2013a/toolbox/signal/signal/@fdesign/@abstracttypewspecs/schema.p>set_specificationtype (line 65)
trettberg commented 8 years ago

By executing the test function for the IIR pre-filter from current master [...] I got the following error [...]

Cannot reproduce. Test is passed from current master (da8d4c5) with R2012b, R2013a and R2013b, Linux.

hagenw commented 8 years ago

I still get an error:

>> test_wfs_iir_prefilter
Error using fdesign.arbmag/set
There is no enumerated value named 'Nb,Na,F,A'.

Error in fdesign.abstracttypewspecs/schema>set_specificationtype (line 64)

Error in fdesign.abstracttypewspecs/abstract_setspecs (line 24)
    set(this, 'SpecificationType', varargin{1});

Error in fdesign.abstracttypewspecs/setspecs (line 7)
abstract_setspecs(this, varargin{:});

Error in fdesign.arbmag (line 119)
this.setspecs(varargin{:});

Error in wfs_iir_prefilter (line 137)
d = fdesign.arbmag('Nb,Na,F,A',Nb,Na,F,abs(H)); %we only consider abs, due to the desired minphase design

Error in test_wfs_iir_prefilter (line 54)
hpre1 = wfs_iir_prefilter(conf)

Linux, Matlab 2015a:

>> ver
----------------------------------------------------------------------------------------------------
MATLAB Version: 8.5.0.197613 (R2015a)
MATLAB License Number: 559163
Operating System: Linux 4.3.0-1-amd64 #1 SMP Debian 4.3.3-7 (2016-01-19) x86_64
Java Version: Java 1.7.0_60-b19 with Oracle Corporation Java HotSpot(TM) 64-Bit Server VM mixed mode
----------------------------------------------------------------------------------------------------
MATLAB                                                Version 8.5        (R2015a)
Optimization Toolbox                                  Version 7.2        (R2015a)
Partial Differential Equation Toolbox                 Version 2.0        (R2015a)
Signal Processing Toolbox                             Version 7.0        (R2015a)
Symbolic Math Toolbox                                 Version 6.2        (R2015a)
trettberg commented 8 years ago

It looks like the DSP System Toolbox is required.

hagenw commented 8 years ago

This sounds reasonable. I added a check for the DSP System Toolbox and pushed it into the master. Can you please check, if it finds the toolbox for you and continues.

For me it stops now with the following error under Matlab:

>> test_wfs_iir_prefilter
Error using wfs_iir_prefilter (line 98)
WFS_IIR_PREFILTER: The DSP System Toolbox is required for IIR filter, please use conf.wfs.hpretype="FIR"

Error in test_wfs_iir_prefilter (line 54)
hpre1 = wfs_iir_prefilter(conf)

And this error is returned under Octave:

>> test_wfs_iir_prefilter
error: WFS_IIR_PREFILTER: Not available under Octave, please use conf.wfs.hpretype="FIR"
error: called from
    wfs_iir_prefilter at line 93 column 5
    test_wfs_iir_prefilter at line 54 column 7
trettberg commented 8 years ago

Works fine here.

hagenw commented 8 years ago

Ok, perfect.