search

sfstoolbox / sfs-matlab

SFS Toolbox for Matlab/Octave
https://sfs-matlab.readthedocs.io
MIT License
98 stars 39 forks source link

Clean up delayline() #30

Closed hagenw closed 8 years ago

hagenw commented 9 years ago

e39a0ae0503d09e75283064e0402a1ddc0ccdb41 introduces a new handling of delayline() which can now handle the default SOFA impulse response matrices in the form of [M C N], where

M ... number of measurements
C ... number of channels
N ... Number of samples

This has some benefits as for example the sofa_get_data() function returns the data in that format which is much easier to handle for smooth SOFA integration. Before we always used [N C] as the standard input format and several measurements were simply put into channels if needed. At the moment both ways are supported by the current delayline() implementation, but we could consider to remove the [N C] completely in order to simplify and fasten the code, which is critical for this particular function.

hagenw commented 8 years ago

As it is very convenient to have both behaviors and it is still fast, we will support both input formats [M C N] and [N C].