search

sfstoolbox / theory

Theory of sound field synthesis
https://sfs.readthedocs.io
Creative Commons Attribution 4.0 International
14 stars 3 forks source link

Nfchoa line sources #12

Closed hagenw closed 8 years ago

hagenw commented 8 years ago

Hi @narahahn.

I added a few lines to the documentation for your 2.5D and 3D versions of the NFC-HOA driving functions for line sources.

In addition I included some of your remarks, regarding the introduction of spherical coefficients etc. Its still includes the directional dependency of the source model as I still think that there is some directional dependency. Could you please review my additions and maybe start adding further corrections to the introduction at the beginning as I forgot your proposal we discussed in Rostock.

In order to view the changes on your local machine compile the documentation from the root dir via make html-preview and then go to _build/html-preview/index.html and open that file in a browser.

hagenw commented 8 years ago

I updated it to the latest version of our documentation web page and you can have a look at my changes at http://sfstoolbox.org/en/nfchoa_line_sources/.

The functions I added or modified are http://sfstoolbox.org/en/nfchoa_line_sources/#equation-D_planar http://sfstoolbox.org/en/nfchoa_line_sources/#equation-line-source-spherical-coefficients http://sfstoolbox.org/en/nfchoa_line_sources/#equation-D.nfchoa.ls.3D http://sfstoolbox.org/en/nfchoa_line_sources/#equation-D.nfchoa.ls.2D http://sfstoolbox.org/en/nfchoa_line_sources/#equation-D.nfchoa.ls.2.5D

hagenw commented 8 years ago

OK, thanks, I should read more about line sources ;)

Are you otherwise finished and I can merge it?

narahahn commented 8 years ago

It's my great pleasure, Hagen. I have nothing else regarding the line source driving functions. I am reading through the entire document and found some points I want to discuss. Should I just write an e-mail or open an issue?

hagenw commented 8 years ago

Thanks, I will merge it.

Regarding new discussion, you could decide which way you prefer. If you decide to create an issue, it would be nice to have different issues for different parts of the discussion. But it is also fine to start with one mail and then create pull requests with solutions for the different points.