search

sftcd / openssl

TLS/SSL and crypto library
https://www.openssl.org
Apache License 2.0
46 stars 20 forks source link

macOS build error #9

Closed patrickkh7788 closed 4 years ago

patrickkh7788 commented 4 years ago

with last commit:

cc  -I. -Iinclude  -DAES_ASM -arch x86_64 -O3 -Wall -DL_ENDIAN --DNDEBUG -Iinclude  -c -o ssl/libssl-lib-ssl_rsa.o ssl/ssl_rsa.c
ssl/esni.c:3076:28: error: no member named 'st_mtim' in 'struct stat'
    time_t privmod=pubstat.st_mtim.tv_sec;
                   ~~~~~~~ ^
ssl/esni.c:3077:37: error: no member named 'st_mtim' in 'struct stat'
    time_t pubmod=(pubfname?pubstat.st_mtim.tv_sec:0);
sftcd commented 4 years ago

Hiya,

On 27/11/2019 15:53, patrickkh7788 wrote:

with last commit:


cc  -I. -Iinclude  -DAES_ASM -arch x86_64 -O3 -Wall -DL_ENDIAN --DNDEBUG -Iinclude  -c -o ssl/libssl-lib-ssl_rsa.o ssl/ssl_rsa.c
ssl/esni.c:3076:28: error: no member named 'st_mtim' in 'struct stat'
    time_t privmod=pubstat.st_mtim.tv_sec;
                   ~~~~~~~ ^
ssl/esni.c:3077:37: error: no member named 'st_mtim' in 'struct stat'
    time_t pubmod=(pubfname?pubstat.st_mtim.tv_sec:0);

Thanks. I don't have access to a mac to build on, but a colleague might. If you have a patch/PR that fixes, be happy to accept that.

Thanks again, S.

patrickkh7788 commented 4 years ago

use st_mtimespec replace st_mtim for macro __APPLE__ should fix this.

sftcd commented 4 years ago

On 27/11/2019 16:20, patrickkh7788 wrote:

use st_mtimespec replace st_mtim for macro APPLE should fix this.

Great thanks, colleague trying now.

S.

sftcd commented 4 years ago

On 27/11/2019 16:20, patrickkh7788 wrote:

use st_mtimespec replace st_mtim for macro APPLE should fix this.

Thanks, that seemed to fix the build on my colleague's machine so I've pushed the change.

patrickkh7788 commented 4 years ago

one more error with macOS:

ar r providers/liblegacy.a 
ar r providers/libnonfips.a providers/common/libnonfips-lib-nid_to_name.o providers/common/libnonfips-lib-provider_util.o providers/implementations/ciphers/libnonfips-lib-cipher_aes_xts_fips.o providers/implementations/kdfs/libnonfips-lib-pbkdf2_fips.o

ar r providers/libnonfips.a providers/common/libnonfips-lib-nid_to_name.o providers/common/libnonfips-lib-provider_util.o providers/implementations/ciphers/libnonfips-lib-cipher_aes_xts_fips.o providers/implementations/kdfs/libnonfips-lib-pbkdf2_fips.o
ar: creating archive providers/libimplementations.a
ar: no archive members specified
usage:  ar -d [-TLsv] archive file ...
    ar -m [-TLsv] archive file ...
    ar -m [-abiTLsv] position archive file ...
    ar -p [-TLsv] archive [file ...]
    ar -q [-cTLsv] archive file ...
    ar -r [-cuTLsv] archive file ...
    ar -r [-abciuTLsv] position archive file ...
    ar -t [-TLsv] archive [file ...]
    ar -x [-ouTLsv] archive [file ...]
make[1]: *** [providers/liblegacy.a] Error 1
make[1]: *** Waiting for unfinished jobs....
ar: creating archive providers/libnonfips.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: providers/libimplementations.a(libimplementations-lib-scrypt.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: providers/libimplementations.a(libimplementations-lib-x942kdf.o) has no symbols
/opt/d/.PREFIX/bin/ranlib providers/libimplementations.a || echo Never mind.
/opt/d/.PREFIX/bin/ranlib providers/libnonfips.a || echo Never mind.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: providers/libimplementations.a(libimplementations-lib-scrypt.o) has no symbols
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: providers/libimplementations.a(libimplementations-lib-x942kdf.o) has no symbols
make: *** [build_libs] Error 2
sftcd commented 4 years ago

Sorry forgot about that one - did you resolve it?