search

sftcd / wkesni

A well-known URI for publishing ESNIKeys
7 stars 2 forks source link

unknown keys in JSON and IANA changes #19

Closed sftcd closed 3 months ago

sftcd commented 3 months ago

An issue from an early dnsdir review

  • What happens if there are unknown keys in the JSON? (e.g, is the response considered invalid? Or does the Zone Factory ignore them and create the RRs anyway?) * how are changes to the underlying SVCB service parameter registry handled? This I-D asks IANA to create another registry for the JSON fields. Does this have to "keep up" with the SVCB IANA registry?
sftcd commented 3 months ago

I guess we still need to say something about what ZF does if it doesn't recognise some of the JSON stuff, in particular unknown SvcParamKeys.

For reference, the IANA registry for those is here. The ones there now that my bash code doesn't know about are dohpath (probably not relevant for web servers?) and ohttp, which could be relevant I guess.

The obvious choices are to ignore such or for the ZF to fail and not update the DNS. I guess fail is the safe option, so might be best to go for that for now and see where discussion goes? If so, I can make a PR for that.

richsalz commented 3 months ago

Fail on unknown seems the safest. But it could lead to different ZFs having different actions if they don't update what extensions they know about all in-sync. That's probably worth mentioning in the discussion.

sftcd commented 3 months ago

Resolved (for now) by #23