search

sfu-db / connector-x

Fastest library to load data from DB to DataFrames in Rust and Python
https://sfu-db.github.io/connector-x
MIT License
1.85k stars 147 forks source link

Support for Trino #438

Open romanzdk opened 1 year ago

romanzdk commented 1 year ago

Please add support for Trino SQL engine

antonysouthworth-halter commented 11 months ago

+1 on this, I feel like it should not be too difficult given there is already the official DBAPI wrapper https://github.com/trinodb/trino-python-client

zeddit commented 10 months ago

+1, but it seems trino is using http as interface, thus won't be accelerated too much.

wseaton commented 10 months ago

Here's an example Trino Rust client implementation: https://github.com/joshthoward/trino-rust-client, it's basically just a wrapper around a few REST API calls. There are also very tricky things like supporting OAuth and automatically de-serializing the data into an Arrow table format that are absent.

Benchmarking that (as the best case) against the python bindings might show if there is a room for speedup, but I doubt much is to be gained.