sfu-db / connector-x

Fastest library to load data from DB to DataFrames in Rust and Python
https://sfu-db.github.io/connector-x
MIT License
1.94k stars 154 forks source link

Update typesystem.rs, added MYSQL_TYPE_NULL #542

Open luca-trigili opened 1 year ago

wangxiaoying commented 1 year ago

Hi @luca-trigili , thanks for the PR!

Can you also add a test for the null type in our CI? You can refer to this commit: https://github.com/Amar1729/connector-x/commit/3391f71869f25d66e586999bbc6ba8866d99aed6 which adds a new type to postgres. Basically you need to add a new test type null to mysql.sql (new column in create table, insert values) and then modify corresponding tests (here and here) in test_mysql.py by checking the result of this new type.