feat: Supports structured construction of database connection.

sfu-db / connector-x

Fastest library to load data from DB to DataFrames in Rust and Python

https://sfu-db.github.io/connector-x

MIT License

1.85k stars 146 forks source link

feat: Supports structured construction of database connection. #613

Closed zen-xu closed 2 months ago

zen-xu commented 2 months ago

This PR can provide some type hints to help build a DB connection.

wangxiaoying commented 2 months ago

Thanks @zen-xu for the PR! This feature could be very helpful. : )

One minor comment is that can you rename the Connection class to ConnectionStr or ConnectionURL ? Otherwise one may think it as a real database connection like the ones supported pandas instead of the url for it. Thank you!

zen-xu commented 2 months ago

Hi @wangxiaoying, ready to merge