Closed pangjunrong closed 1 month ago
Hi @pangjunrong , thanks for the PR. It looks good to me.
Can you fix the formatting problem of the code? You can do it by running cargo fmt
.
Also, can you add this new parameter to the documentation here as well? You can do this by editing this markdown file.
P.S., You may also need to upgrade the version of tiberius in order to have the _ca function.
Hey @wangxiaoying, thanks for the quick reply! I've fixed the formatting and added the new parameters into the documentation.
So I updated tiberius & bb8-tiberius to 0.7.3 and 0.8.0 respectively as those versions contain the first instances of _ca function but I noticed that anything above tiberius 0.5.16 no longer contained the QueryResult method (unfortunately deprecated) which is used across the MSSQL implementation. I've tried my hand at replacing it with the new QueryStream method; hoping you can help out on this if you see anything amiss!
Thank you @pangjunrong !
When establishing an SSL connection to MSSQL currently, bb8 times out due to a mismatch in CA certificates since underlying default behavior from tiberius is to validate server certificate against system-truststore.
This change enables 2 new parameters in the connection string for MSSQL to address custom CA certificate use cases (description extracted from tiberius config documentation):
This will resolve issue #509 and is a requested feature at the end of the thread.