search

sfu-db / dataprep

Open-source low code data preparation library in python. Collect, clean and visualization your data in python with a few lines of code.
http://dataprep.ai
MIT License
2.02k stars 204 forks source link

The "country" param not working for "top_artist" from "musixmatch" #534

Closed yikun27 closed 3 years ago

yikun27 commented 3 years ago

Describe the bug No matter how I change the country name, the "top_artisit" returns the same output. So it looks like the country parameter is not working here.

To Reproduce Steps to reproduce the behavior:

Code from dataprep.connector import connect conn = connect("musixmatch", _auth={'access_token':'40acad758db****2fb2ea271'}, _count =1000)

All following codes produce the same results, so the country is not useful in the input: Screenshots await conn.query('top_artists',country ='Japan') 1

await conn.query('top_artists') 2

await conn.query('top_artists', country='US') 3

Expected behavior I believe the output should be selected based on the records within that country if we have a country name in the input. But we see the outputs are all the same nomatter whether we select country or not.

Desktop (please complete the following information):

Additional context

peiwangdb commented 3 years ago

Hi @yikun27 thanks for the report. The country parameter is defined as the "A valid country code (default US)" according to the documentation here: https://developer.musixmatch.com/documentation/api-reference/artist-chart-get. So I tried to set the country as "Japan" and "JP". The results are different on my side. I hope this addresses the issue.